On Thu, Mar 7, 2013 at 5:32 PM, zalew <[email protected]> wrote: > fall back to SimpleTestCase (which > TransactionTestCase inherits from), but this class doesn't contain useful > test helpers, which aren't in any way related to db handling: > > * assertRedirects > * assert(Not)Contains > * assertFormError > * assertTemplate(Not)Used > * _urlconf_setup(teardown). > > Is there a reason why these functions were bound to a transaction handling > test class instead of SimpleTestCase? > > My proposal is to move them out either to SimpleTestCase, or a separate > class other tests (including TransactionTestCase) can inherit from. I have > experimentally written a SimpleTestCase based class for my needs, but I > haven't yet tested it against the Django suite. > > What do you think? If you agree and/or have some ideas, I will submit an > issue and work on a patch proposal.
We inserted [1]SimpleTestCase in the hierarchy relatively [2]recently (Django 1.4) and moved some functionality to it from its subclasses. But at that time I didn't even think about challenging the status quo and move all the non-DB related like you've just done. +1 to you proposal. Please open a ticket. This thread and the ticket should give the topic the visibility it needs to raise alarms if there is any backward compatibility involved. Thanks! 1. https://docs.djangoproject.com/en/1.5/topics/testing/overview/#django.test.SimpleTestCase 2. https://docs.djangoproject.com/en/1.5/releases/1.4/#minor-features -- Ramiro Morales @ramiromorales -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
