Thanks Claude, I have the code and tests ready, but should I run the tests (can't figure how to setup django so it would run this package test, and when I try to run python tests.py directly I get a missing django settings something or another missing ) or does the jenkins server run it automatically and I should just submit the code?
On Saturday, March 9, 2013 6:10:40 PM UTC+2, Claude Paroz wrote: > > Le samedi 9 mars 2013 10:46:27 UTC+1, Alon Nisser a écrit : >> >> I'm working on translating and adding to >> django_localflavor_il<https://github.com/alonisser/django-localflavor-il>. >> and I have a couple of questions: >> >> >> 1. I'm adding another field (an Israeli mobile phone number), should >> I open a ticket somewhere? >> >> Yes, here: https://github.com/django/django-localflavor-il/issues > >> >> 1. what is the proper process of contributing? I forked the repo, >> added the validation and tests now what? just make a pull request? >> >> Yes, a pull request is indicated. > >> >> 1. following this >> topic<https://groups.google.com/forum/#!topic/django-developers/OiyEGmXTifs>: >> is >> using django_localflavor_xx still recommended? am I working on the wrong >> issue? >> 2. after adding the form field and validation I need to translation >> another string to the po file. how do I 'extract messages' from this >> package? >> >> cd into the inner django_localflavor_il directory and run > "django-admin.py makemessages -l en" to update the > locale/LC_MESSAGES/django.po file or "django-admin.py makemessages -a" to > update all po files. > > HTH, > > Claude > > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
