On Thursday, April 18, 2013 7:59:59 PM UTC+2, Michael Manfre wrote: > > A few questions and comments. > > - The potentially huge performance hit would need to be called out in the > documentation. Hit would be from more queries and less opportunities (more > complexity) to cache filter options. >
That goes without saying that performance must be mentioned :) > > > - What should happen if not all of the filters on a ModelAdmin support > being incremental? Exception, allow some filters to yield empty results, or > some other behavior? > All default `FieldListFilter`s are supporting it (patch). As for custom FIlters - subclasses of `SimpleListFilter` - it could be made `incremental aware` but to make it really 'incremental' would be user's responsibility (and decision in the first place) ? > - It might be better to add a CSS class to the filter options that would > yield and empty result. Doing so would address Augustin's comment about > finding empty results as being useful and it allows changing a filter from > "Older than 6 months" to "Older than 1 month" without having to select > "All" in between. The options could be hidden with CSS to match the > proposed behavior. > Oh yeah, I was thinking about making the 'empty' choices less visible... but this is better. -Przemek -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
