On 12 juil. 2013, at 22:47, Tim Graham <timogra...@gmail.com> wrote:

> formset.save(commit=False) on ModelFormSets currently deletes any objects 
> marked for deletion which seems like a bug to me, since I wouldn't expect any 
> data changing operations when using commit=False. I put together a pull 
> request to address #10284 which includes a doc update indicating that it's 
> backwards incompatible (bug fixes are) and how to account for the new 
> behavior.

Yes, that's what I would do too.

> I then came across #17988 which takes a different approach by keeping the 
> current behavior of formset.save(commit=False)deleting objects, but allowing 
> you to call formset.save() a second time after calling 
> formset.save(commit=False)[currently the second save() would throw an 
> exception due to the objects being deleted on the first save(commit=False) 
> call].

That doesn't sound intuitive.

-- 
Aymeric.


-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to