This seems like a reasonable change. I don't love the fact that the contrib.auth built in forms quasi support custom user models, as it leads to a less clear delineation about what parts of contrib.auth are tightly coupled auth the default User model.
https://docs.djangoproject.com/en/1.5/topics/auth/customizing/#custom-users-and-the-built-in-auth-forms This doesn't warrant a backport for 1.6 though - as it is currently easy to override this in your own form, and 1.6 is in feature-freeze beta. -Preston On Friday, August 2, 2013 9:20:58 AM UTC-7, Anders Steinlein wrote: > > Hi all, > > I have implemented a custom user model that extends AbstractBaseUser, > where an EmailField is set as the USERNAME_FIELD. Logging in with a default > auth login view and AuthenticationForm works nicely, however, the username > field is still a CharField and thus rendered as a regular input field. I'm > using Django 1.6 where I was expecting a type='email' input field. > > How about we change the widget of the username field in > AuthenticationForms __init__ method based on USERNAME_FIELD? If yes, would > it be too late to sneak this into 1.6 given the new use of HTML5 input > types? I'm happy to provide a patch. > > > *Anders Steinlein* > *Eliksir AS* > http://e5r.no > > E-post: and...@e5r.no <javascript:> > Mobil: +47 926 13 069 > Twitter: @asteinlein > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. For more options, visit https://groups.google.com/groups/opt_out.
