Hi Michael, On 22 sept. 2013, at 22:48, Michael Manfre <[email protected]> wrote:
> On Sun, Sep 22, 2013 at 3:18 PM, Aymeric Augustin > <[email protected]> wrote: > > The extra queries for the savepoints will break all tests that use > assertNumQueries > — well, all except assertNumQueries(0). How do you propose to deal with that. > > When changes are made to Django in such a way that existing tests no longer > accurately test the expected behavior, I propose that the tests are fixed. > > I'd argue that many of the tests that use assertNumQueries are poorly written > and should be viewed as already broken. This opinion is based upon my efforts > of making django-mssql pass the test suite. Yes, I agree with that as far as Django's own test suite is concerned. I was more worried about our end users' test suites. Currently, if you don't use transactions, you can ignore the new transaction management entirely. If all your assertNumQueries start failing, it's another story. -- Aymeric. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. For more options, visit https://groups.google.com/groups/opt_out.
