El viernes, 16 de mayo de 2014 09:49:15 UTC-3, Andrew Godwin escribió: > > Let's go with a feature for this then. > > Maxi, did you want to submit a patch, or do you want me to add it at some > point next week! > > Andrew >
I'll appreciate if you can add it. BTW, are there other areas that need some work, for instance, add_field method [1], if I try to delete a default value on a column that does not have a previous default value definition I get an error on firebird, for which reason, I need to check if that field has got defined a default value before. Then I need to rewrite add_field method too. I think, for not to delay django 1.7 release, I'll do some workaround and I'll try to send you a pull request or a patch with some proposal later. [1] https://github.com/django/django/blob/master/django/db/backends/schema.py#L401 Best regards. > > > On Wed, May 14, 2014 at 6:27 PM, Aymeric Augustin < > aymeric....@polytechnique.org <javascript:>> wrote: > >> For what it’s worth, I recently added a feature to add “FROM DUAL” where >> Oracle needs it. >> >> This looks roughly similar. Maybe we could use the same approach. (I >> didn’t look closely.) >> >> -- >> Aymeric. >> >> >> >> On 14 mai 2014, at 17:06, Andrew Godwin <and...@aeracode.org<javascript:>> >> wrote: >> >> Hmm, I'm not sure about adding more features, but it might be cleaner... >> >> Andrew >> >> >> On Wed, May 14, 2014 at 8:00 AM, Jeremy Dunck <jdu...@gmail.com<javascript:> >> > wrote: >> >>> How about adding a flag to Operations? implied_null, perhaps. >>> On May 14, 2014 7:52 AM, "Andrew Godwin" <and...@aeracode.org<javascript:>> >>> wrote: >>> >>>> Hi, >>>> >>>> That's currently the only approach I'm afraid - there's an open issue >>>> (raised by Shai Berger I believe) that column_sql should be broken down >>>> into more component pieces so it can be more easily changed, but that's a >>>> difficult task to do and not something I want to go and change completely >>>> as we're trying to release 1.7. >>>> >>>> What we could do is change those NULL and NOT NULL strings to be >>>> defined on the schema editor class itself, and then you could set >>>> sql_null_suffix = "" or similar - do you think that would be a reasonable >>>> approach? >>>> >>>> Andrew >>>> >>>> >>>> On Wed, May 14, 2014 at 7:05 AM, maxi <maxir...@gmail.com <javascript:> >>>> > wrote: >>>> >>>>> Hi, >>>>> >>>>> I'm trying to implement the new schema migration of django 1.7 for >>>>> django-firebird backend. >>>>> In column_sql method, when the field can be null, in firebird, is not >>>>> necessary add the NULL keyword. So to change this behavior I need >>>>> override >>>>> the entire column_sql method just to change one line: >>>>> >>>>> >>>>> if null: >>>>> sql += " NULL" <-- Here >>>>> else: >>>>> sql += " NOT NULL" >>>>> >>>>> I just need: >>>>> if not null: >>>>> sql += " NOT NULL" >>>>> >>>>> >>>>> Is the correct approach rewrite the column_sql method? Are there other >>>>> approach? >>>>> >>>>> Regards. >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Django developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to django-develop...@googlegroups.com <javascript:>. >>>>> To post to this group, send email to >>>>> django-d...@googlegroups.com<javascript:> >>>>> . >>>>> Visit this group at http://groups.google.com/group/django-developers. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/django-developers/e9f24444-a5bf-4e13-b7c1-0a08abd18a4a%40googlegroups.com<https://groups.google.com/d/msgid/django-developers/e9f24444-a5bf-4e13-b7c1-0a08abd18a4a%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Django developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to django-develop...@googlegroups.com <javascript:>. >>>> To post to this group, send email to >>>> django-d...@googlegroups.com<javascript:> >>>> . >>>> Visit this group at http://groups.google.com/group/django-developers. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/django-developers/CAFwN1upTtLEmGjz5f2vUBV6kEFDqdiyRyz4GhM3i3WbSyot0aw%40mail.gmail.com<https://groups.google.com/d/msgid/django-developers/CAFwN1upTtLEmGjz5f2vUBV6kEFDqdiyRyz4GhM3i3WbSyot0aw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Django developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to django-develop...@googlegroups.com <javascript:>. >>> To post to this group, send email to >>> django-d...@googlegroups.com<javascript:> >>> . >>> Visit this group at http://groups.google.com/group/django-developers. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/django-developers/CAM0i3f6Jw6Bs8FEeTmU7wVwA3SQKwcruKqtTReCa_-GrxbZmww%40mail.gmail.com<https://groups.google.com/d/msgid/django-developers/CAM0i3f6Jw6Bs8FEeTmU7wVwA3SQKwcruKqtTReCa_-GrxbZmww%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to django-develop...@googlegroups.com <javascript:>. >> To post to this group, send email to >> django-d...@googlegroups.com<javascript:> >> . >> Visit this group at http://groups.google.com/group/django-developers. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/CAFwN1urWNpLhc4_1wc-dFVSJJDkdWvud0UaDnCc11suTE986vw%40mail.gmail.com<https://groups.google.com/d/msgid/django-developers/CAFwN1urWNpLhc4_1wc-dFVSJJDkdWvud0UaDnCc11suTE986vw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to django-develop...@googlegroups.com <javascript:>. >> To post to this group, send email to >> django-d...@googlegroups.com<javascript:> >> . >> Visit this group at http://groups.google.com/group/django-developers. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/8F3A2FC4-6CA5-406A-90F5-63E1E4A6945E%40polytechnique.org<https://groups.google.com/d/msgid/django-developers/8F3A2FC4-6CA5-406A-90F5-63E1E4A6945E%40polytechnique.org?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/9836fa63-1750-4b0b-bc7e-76efcd9316cd%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
