Hi Curtis,

Of course! I will be happy to open a document with my performance tuning 
experience. Said this, I am very far away from being a "performance master" 
and I am still looking at places where my code can improve. It would be 
nice if it was a wiki page, where everyone can share and correct. 
Collective knowledge!
Where would you like me to write the document?

On Saturday, July 5, 2014 12:38:00 PM UTC+2, Curtis Maloney wrote:
>
> Can I ask as a favour to future works that you record all the performance 
> tuning approaches you use?
>
> Many of these will be obvious to seasoned Python programmers, but some of 
> them won't be, and it would be nice to have a catalogue of "things to look 
> out for" to apply to critical paths in Django.
>
> --
> Curtis
>
>
>
> On 5 July 2014 20:11, Josh Smeaton <[email protected] <javascript:>> 
> wrote:
>
>> Excellent work, well done. I have a couple of questions/ideas though.
>>
>> 1. The use of bit flags irks me. Would it be possible just to use 
>> numerous keyword arguments to the new get_fields ?
>> 2. Since you've reduced the API to effectively two functions (get_fields, 
>> get_field), is it still necessary to contain those methods on an inner 
>> object? Can't the new methods live directly on the model? If they can't be 
>> put directly on the model for some reason, I would consider a better name 
>> than "meta". I can't think of a reason that the name meta should be used 
>> other than history. If you were to think about the purpose of the API 
>> without the associated history, what would you call it?
>>
>> log = Log.objects.get(pk=1)
>> log.get_fields(concrete=True, m2m=True, related=True)
>>
>> log.get_field('log_level') # we're being explicit about the field name, 
>> no need for options
>>
>>
>> Thoughts?
>>
>> I'll take a better look at the PR and see if I can offer anything with 
>> regards to your performance optimisations.
>>
>> Josh 
>>  
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Django developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to [email protected] <javascript:>.
>> To post to this group, send email to [email protected] 
>> <javascript:>.
>> Visit this group at http://groups.google.com/group/django-developers.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/django-developers/7496ef6d-4e88-41f4-b2b8-1bd2efa96aea%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/django-developers/7496ef6d-4e88-41f4-b2b8-1bd2efa96aea%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>>
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/ccf5ffb4-dd3c-492a-80e6-eaae77934373%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to