Hi Nick, Personally, I think this is a great start. I would like to hear input from others.
I appreciate the work you put into manually resolving those jshint warnings. The qunit test style looks good to me too. I added some comments on the pull request with some suggestions for improvements. The biggest suggestions I made in the PR: 1. The Gruntfile.js and package.json should be moved to the top level 2. Use 4 spaces for all code in the PR (it's mostly 2 spaces currently) Thanks for taking the initiative on this! On 08/01/2014 05:29 PM, Nick Sandford wrote: > So, I have been working a little on a PR for this > (https://github.com/django/django/pull/3003) and having spoken to Tim > briefly about getting this supported in jenkins I just wanted to check > that the approach was OK. The tests use node, grunt, qunit, istanbul and > jshint. Is this a reasonable approach? Some of the responses here are > using a similar stack. > > > On Mon, May 5, 2014 at 7:19 AM, Trey Hunner <[email protected] > <mailto:[email protected]>> wrote: > > I started a rough draft of a DEP for adding unit tests for Django's > JavaScript: https://github.com/django/deps/pull/4 > > I am suggesting that a native JavaScript test framework be used > *without* attempting to use an adapter to run the tests under the Django > test framework. I anticipate that this suggestion may require further > explanation and debate, so I have submitted a pull request for > discussion while I continue to extend the DEP. > > > -- > You received this message because you are subscribed to the Google > Groups "Django developers" group. > To unsubscribe from this group and stop receiving emails from it, > send an email to [email protected] > <mailto:django-developers%[email protected]>. > To post to this group, send email to > [email protected] > <mailto:[email protected]>. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > > https://groups.google.com/d/msgid/django-developers/53672D8A.2050005%40treyhunner.com. > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google > Groups "Django developers" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected] > <mailto:[email protected]>. > To post to this group, send email to [email protected] > <mailto:[email protected]>. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CAMwcc5WuxZ5yVQQH8wVbX51VHyaXN-ZLyrK_oJeS3e4vo5kqvA%40mail.gmail.com > <https://groups.google.com/d/msgid/django-developers/CAMwcc5WuxZ5yVQQH8wVbX51VHyaXN-ZLyrK_oJeS3e4vo5kqvA%40mail.gmail.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout. -- Trey Hunner http://treyhunner.com -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/53DC7575.2040808%40treyhunner.com. For more options, visit https://groups.google.com/d/optout.
