> Do we now have a consistent set of conversion methods and a clear view of which one does what?
This does need further investigation and testing. In particular I know we are being a bit heavy handed at the moment with a consequential performance hit. The issue is that some backends require converters only in certain cases - most notably on aggregation or in .dates(). By always running the code, we are getting more consistency but at a hit of performance. I intend to work through the built in converters and ensure we have a proper test suite for them at some point, but there are two things to consider - one is upcoming changes to aggregates and the other is that the diff is already 1k lines. > Did you consider adding an example of switching from SubfieldBase to from_db_value in the docs? It's "remove the metaclass, add from_db_value which does a similar thing to to_python but just handles the db case". Someone can always diff 1.7 and 1.8 docs ;) On 26 August 2014 22:03, Aymeric Augustin < [email protected]> wrote: > I support deleting > django.contrib.gis.db.models.sql.compiler.SQLDateTimeCompiler. There's some > code in Django I'm really ashamed of; this class ranks high on the list. > > I've been frustrated by inconsistencies in this area in the past but never > investigated. Overall, your approach looks reasonable and the new API is > useful. Two questions: > > - Do we now have a consistent set of conversion methods and a clear view > of which one does what? > > - Did you consider adding an example of switching from SubfieldBase to > from_db_value in the docs? > > -- > Aymeric. > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/071D2D94-60FF-44C4-90CB-F9CCEB1252C8%40polytechnique.org > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMwjO1GSuCeMZ3x%3DXXMEmjd_DpAt%2BYCXWf8HUtTWL5k6pvEwkA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
