> On Dec 17, 2014, at 6:12 PM, Carl Meyer <c...@oddbird.net> wrote: > > On 12/17/2014 04:57 PM, Ryan Hiebert wrote: >>> >> What would __iadd__ do in this subclass? Would it behave like tuple and >> create a new DjangoList, or would it behave like list and extend the >> original list? > > For maximum backwards-compatibility during the deprecation period, if > it's called with a tuple, it should create and return a new tuple, I > think. That way the deprecation warning only gets fired once for a > particular setting, which is all that's needed, even if they go and add > to the resulting value several more times. > > If it's called with a list, it should behave as a normal list does. > > And before you get too far, you may want to wait and see if any other > core devs step in to tell me I'm crazy and there's no way we should have > a deprecation path just to switch some settings from tuples to lists. > > (I'm only in favor of it myself because I think in practice the impact > will be small.)
Thanks for the warning, and your solution makes perfect sense to me. I’m gonna go ahead and keep working on it for fun, but I understand that we might find that it’s not worth the deprecation period, and I’m OK with that. Thinking about it a bit, I’m going to see if just watching for tuple and returning a tuple, otherwise returning a native list might be sufficient. Ryan -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/8B6067E2-43DF-454A-BC0C-3928239F7C5B%40ryanhiebert.com. For more options, visit https://groups.google.com/d/optout.
