Clause, I believe that line is to allow people to run makemigrations when AUTH_USER_MODEL points to an app that doesn't yet have migrations; before, it would fail hard, as the AUTH_USER_MODEL was not in the migrate state and so nothing could use it, and you couldn't run makemigrations to create it as it would error out.
I'd test variations of that to see if your patch still works; if not, we'll need a workaround again. Andrew On Sat, Dec 20, 2014 at 10:47 AM, Claude Paroz <[email protected]> wrote: > > On Friday, December 19, 2014 6:30:32 PM UTC+1, Tim Graham wrote: >> >> Yes. Claude has worked on the deprecation in https://github.com/django/ >> django/pull/3220 but it requires adding more migrations to our test >> suite and he noted that each migration we add to Django's test suite adds >> up to ~3.5 seconds to the run time of the test suite. He also worked on >> some speed ups to mitigate this in https://github.com/django/ >> django/pull/3484 but there are some unsolved issues. >> > > I think that the first mentioned patch I worked on (PR 3220) shows that it > should be possible to use the new schema infrastructure without requiring > migrations, at least for apps that don't depend on other migrated apps. > Tell me if I miss anything. > > But surely, I'd really like to solve first the speed issue of migrations > (#23745, PR 3484). Chris, if you have the opportunity to test that patch > with your database, it would be great. The way forward for this patch is to > first test the "if app_label == settings.AUTH_USER_MODEL and > ignore_swappable:" line which is currently not tested and is probably not > addressed by my patch. Andrew, do you remember why you introduced that part > of the code? > > Claude > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/1f5f37b2-5309-4af6-8b3c-aa76eee3bde1%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/1f5f37b2-5309-4af6-8b3c-aa76eee3bde1%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAFwN1urVDjwidnzk-%3DrEhvjYCtivcVCrtgpdserQ6B36zMdrxA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
