isort has released a new version, so I've finished this task by merging the cleanups in Django and adding another pull request builder to verify isort doesn't complain on new changes. Documentation is available here: https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/#imports
Hopefully this allows contributors to more easily handle these fixes on their own in advance of a review from a human! On Thursday, February 5, 2015 at 8:55:06 AM UTC-5, Tim Graham wrote: > > Two new builders run on all pull requests: > > - flake8 <http://djangoci.com/job/flake8/> - runs the equivalent of > flake8 from the root checkout directory and fails if there are any > warnings > - docs <http://djangoci.com/job/docs/> - runs the equivalent of make > spelling from the docs directory and fails if there are any spelling > or sphinx errors. > > The spelling builder accidentally triggered on all open PRs so that's why > a lot of them appear as "pending." > > I've submitted a couple patches to isort and am awaiting a new release > there before continuing with that cleanup in Django. > On Friday, January 30, 2015 at 5:22:27 AM UTC-5, Andrew Ingram wrote: >> >> For what it's worth, I prefer one import per line, if only because it >> makes diffs that involve changes to imports a lot easier to digest, and >> usually smaller. >> >> ie, something like this: >> https://gist.github.com/AndrewIngram/16da35699bd495f79adb >> >> >> Andy >> >> >> On 30 January 2015 at 09:36, aRkadeFR <[email protected]> wrote: >> >>> I support the idea of introducing isort. >>> >>> Didn't know isort before and give it a try on personal project. >>> It considers only the global import of the file (I mean on the >>> very top on my files and not in the methods / functions). Which >>> is exactly what it should do from my point of view. >>> >>> >>> On 01/29/2015 02:18 PM, Tim Graham wrote: >>> >>> As a code reviewer, I've really appreciated that we've cleaned up the >>> code using flake8 and have automated "enforcement" via the CI server. I'd >>> like to extend the idea to apply to standardizing import ordering using >>> isort [1]. This mail is to advise everyone of the change and to address any >>> concerns. >>> >>> Documentation: >>> https://github.com/django/django/pull/4008 >>> >>> Automated cleanups: >>> https://github.com/django/django/pull/4009 >>> >>> On a related note, the UI for flake8 errors isn't currently very good >>> (you have to look at the bottom of the Jenkins build logs). I'd like to >>> improve that by using a separate service that uses the GitHub status API >>> [2] so that the check can run separately from the tests build. I don't want >>> to reinvent the wheel though, so if there is an existing service we can use >>> for this, great. I'd like to also add checks for documentation build and >>> spelling errors, as well as isort checks (assuming adoption per above). >>> >>> [1] https://github.com/timothycrosley/isort#readme >>> [2] >>> https://github.com/blog/1935-see-results-from-all-pull-request-status-checks >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Django developers (Contributions to Django itself)" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To post to this group, send email to [email protected]. >>> Visit this group at http://groups.google.com/group/django-developers. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/django-developers/d356e388-fa45-4fdf-871f-ce484a7b43bf%40googlegroups.com >>> >>> <https://groups.google.com/d/msgid/django-developers/d356e388-fa45-4fdf-871f-ce484a7b43bf%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Django developers (Contributions to Django itself)" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To post to this group, send email to [email protected]. >>> Visit this group at http://groups.google.com/group/django-developers. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/django-developers/54CB5092.90507%40arkade.info >>> >>> <https://groups.google.com/d/msgid/django-developers/54CB5092.90507%40arkade.info?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/f08b6005-b184-4939-bac6-4681c57c392f%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
