Hi Andriy, If we're going down this path, I can't think of any reason we wouldn't target ever available aggregate. It doesn't need to be all in one patch/PR - in fact, I'd suggest that unless the implementations are particularly intertwined, one patch per aggregate (or aggregate group - e.g., all the bit_* aggregates) would be preferable.
The only other thing I'd flag is that if any of these aggregates are recent additions (e.g., added in Postgres 9), the failure mode for earlier versions should be relatively clean. Yours, Russ Magee %-) On Sun, Feb 8, 2015 at 9:27 AM, Andriy Sokolovskiy (coldmind) < sokand...@yandex.ru> wrote: > OK, since ticket was market as accepted, should *all* aggregates functions > from http://www.postgresql.org/docs/9.4/static/functions-aggregate.html > be implemented ? I'm asking to prevent doing unnecessary work. > > воскресенье, 8 февраля 2015 г., 1:11:08 UTC+2 пользователь Andriy > Sokolovskiy (coldmind) написал: > >> I opened a ticket for it. >> https://code.djangoproject.com/ticket/24301 >> >> суббота, 7 февраля 2015 г., 18:51:34 UTC+2 пользователь Michael Manfre >> написал: >>> >>> It's reasonable to support backend specific aggregate functions. The >>> database backend API contains >>> BaseDatabaseOperations.check_expression_support >>> for this exact reason. Feel free to create the ticket. >>> >>> Regards, >>> Michael Manfre >>> >>> On Sat, Feb 7, 2015 at 9:00 AM, Andriy Sokolovskiy (coldmind) < >>> soka...@yandex.ru> wrote: >>> >>>> So, since django has contrib.postgres, maybe it would be reasonable to >>>> add postgres-specific aggregate functions to this module? >>>> If it is good idea, I'm gonna create ticket and implement this. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Django developers (Contributions to Django itself)" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to django-develop...@googlegroups.com. >>>> To post to this group, send email to django-d...@googlegroups.com. >>>> Visit this group at http://groups.google.com/group/django-developers. >>>> To view this discussion on the web visit https://groups.google.com/d/ >>>> msgid/django-developers/2d3b2bd2-3bce-4e40-8383- >>>> ef5ca328bc26%40googlegroups.com >>>> <https://groups.google.com/d/msgid/django-developers/2d3b2bd2-3bce-4e40-8383-ef5ca328bc26%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/38e08166-a475-4214-8055-e81eeb452c85%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/38e08166-a475-4214-8055-e81eeb452c85%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAJxq84_9fJnaePpNBaqRbUsmLmybwLtcwvTJ%3Dq87tBSSXmd2kw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
