Is it a best practice? In my unscientific sampling, none of the following 
ship tests inside the application directory, but rather in a separate 
"tests" directory. Or did I misunderstand what you meant?

- Django REST framework
- django-nap
- the apps that split out from contrib (formtools, comments, localflavor)

On Monday, February 9, 2015 at 5:28:22 PM UTC-5, Curtis Maloney wrote:
>
> Just to shine a light on another perspective- I frequently tell people to 
> look at contrib for "best practices", and including tests within a 3rd 
> party app would fall under that.
>
> --
> Curtis
> On 10 Feb 2015 03:34, "Marc Tamlyn" <marc....@gmail.com <javascript:>> 
> wrote:
>
>> +1 to removing tests from contrib itself, so long as they remain 
>> obviously separated in the test section in case of future removals from 
>> core.
>>
>> On 9 February 2015 at 15:44, Preston Timmons <preston...@gmail.com 
>> <javascript:>> wrote:
>>
>>> I think the "need" is mainly conceptual--whether tests are more 
>>> appropriately grouped with their app or with the other tests. With the 
>>> discover runner it's uncommon that contrib tests are included in any local 
>>> test runs.
>>>
>>> I do prefer moving all tests into the tests directory. The logic to get 
>>> test_modules in runtests.py would be simplified quite a bit from it.
>>>
>>>
>>>  -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Django developers (Contributions to Django itself)" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to django-develop...@googlegroups.com <javascript:>.
>>> To post to this group, send email to django-d...@googlegroups.com 
>>> <javascript:>.
>>> Visit this group at http://groups.google.com/group/django-developers.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/django-developers/ba79f1b9-678e-4fdf-8f7a-26319e5ac4d3%40googlegroups.com
>>>  
>>> <https://groups.google.com/d/msgid/django-developers/ba79f1b9-678e-4fdf-8f7a-26319e5ac4d3%40googlegroups.com?utm_medium=email&utm_source=footer>
>>> .
>>>
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>  -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to django-develop...@googlegroups.com <javascript:>.
>> To post to this group, send email to django-d...@googlegroups.com 
>> <javascript:>.
>> Visit this group at http://groups.google.com/group/django-developers.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/django-developers/CAMwjO1EJWzd0G0noSAHFL3ZsOP9kc6He6%2Bb1a5%3DAe3KhxBBfVg%40mail.gmail.com
>>  
>> <https://groups.google.com/d/msgid/django-developers/CAMwjO1EJWzd0G0noSAHFL3ZsOP9kc6He6%2Bb1a5%3DAe3KhxBBfVg%40mail.gmail.com?utm_medium=email&utm_source=footer>
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/4588baf5-2c6f-463c-a994-0ed4fe9a83ba%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to