2015-06-12 0:38 GMT+02:00 Marten Kenbeek <marten.k...@gmail.com>: > The change causes exactly... 1 test failure, > `shortcuts.tests.ShortcutTests.test_render`. It's not even a functional > test, it only fails because > `self.assertFalse(hasattr(response.context.request, 'current_app'))` > fails.The template tests don't even have any namespaced urls, so > `request.current_app` is pretty much untested. >
Some of these tests may not be up to modern standards of writing good tests. At least that's what I remember from refactoring them when I turned the template engine into a library. Sometimes git blame helps find the original author's intentions and improve the tests. -- Aymeric. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CANE-7mXhLMCkd5WH%2BSD3Lo6HOW9w8UGUhquc7cJrn6KpVntjFw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
