On Fri, Jul 3, 2015 at 4:59 PM, Tim Graham <[email protected]> wrote: > Andriy proposed a patch to close objects like StringIO and BytesIO in our > test suite [1]. I am not sure how much benefit this gives (frees "a few > bytes of RAM" according to [2]) and it seems to add a lot of verbosity. > Looking at Python's own test suite, it doesn't appear these objects are > closed there (I spot checked BytesIO and StringIO). Any thoughts on this?
I agree with you on the StringIO and BytesIO cases, but I agree with Andriy on the other usages (e.g. ZipFile, GzipFile). Many contributors follow the existing practices to write new tests, so it would be nice to use best practices if they don't produce too much noise. --Berker -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAF4280KRmDBLm%2BKMywDHsvajOMNq0th%2BhHrt77LV%2BQStNRx4zQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
