-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi,
I've created a PR [0] that applies max. line length of 119 chars to the master branch. Personally, on Firefox-Linux, not all 119 chars are visible on GH, as it's highly dependant of the environment, fonts, dpi, ... With the limit of 113 chars, there are 1051 lines that require modifications. However, because of the way that tests are written (assertEqual) and comparing strings, it's not possible to break the formatting of strings as it will cause tests to fail [1]. Basically, we are stuck with disabling flake8 checks for those lines. I've only spent short amount of time with the codebase, but we should start discussing how to improve "Coding style" document [2], and what kinda style conventions to impose. I'll write an email and list of inconsistencies in the code. Dražen [0] https://github.com/django/django/pull/5224 [1] https://github.com/dodobas/django/commit/b2839a253226d5d2a30c7c9bbe3b8609413c760 f#diff-74c67aea7429ebe5e21f206f24b4418bR2297 [2] https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding - -style/ On 03.09.2015 09:10, anjul.ten wrote: > I think we should consider the minimum character limit i.e. 113 characters > for Chromium, Ubuntu based on the link shared by *Zach Borboa *into > consideration as well. > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV6DjqAAoJEIAOBeNeJzcKqlYH/00qLzRNjtgMvuWg7HhBNibK vCIUOwguZK8R5tUxPkKhCsx3yKmjQ7iaA3OYO6ipBS/wXnvcSPdLOlsAklgxDfwX fgBZ0tHpAyW3Hp/frTCZYp2OvBLDXLsff0DPXopR0xsqeZPdyjTU3yJ/XKqQ7Oys zX8Nw8cp4kvk5dffG+aCzZzzVHK5zJTIH6HoII2jzHH/6WijxJ8miLyeKcd4YdVa ij6e7+7em0dmDTw0XUtLnbRL7yUT8A5I2TA29Qhyj2BzJkV+Zv41A91XQIPxsp8C PuBbinfx7Z2DQ42+YFda+YYidsvVbi+Xm7Rl/Hn7/6SemlnkLJs3Ndxti26dRB8= =fSQh -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/55E838EF.60301%40candela-it.com. For more options, visit https://groups.google.com/d/optout.
