On Monday, September 14, 2015 at 1:54:06 PM UTC+2, jasbligh wrote: > > Perfect, would you know where would be best to place the js in that case? > (I've got the attribute working with the forms framework though) >
Dunno, any existing file which has a few functions should do ;) If the form attribute code is nice, then by all means we should use that… > I'll put the json in views or a filter. There was a very relevant > discussion on this before with a gist by David Evans > https://groups.google.com/forum/#!msg/django-developers/RNMs5YbKeRY/ZtewE89xu_4J > Yes, that library marks the output as safe, which is quote dangerous is not used properly. > If it was my project I wouldn't have a target, that's my preferred style. > But felt if the code already have javascript:void(0) someone felt the need > for a href attribute and as my first contribution I didn't want to be > changing too much. > Ok, removing it should be fine then -- that is unless someone with more frontend experience speaks up :D Cheers, Florian -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/48fd14c2-d217-4623-8305-62ad165f0b18%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.