I agree with the ticket. The imbalance between is_superuser and is_authenticated() should be enough to consider updating the API. The security concerns and, in particular, Aymeric's Jinja example, make this ticket more compelling.
I think we should be asking.. why not? If there's not a good reason not to, let's make it a callable and a property. On Thursday, 3 December 2015 09:09:54 UTC+11, Shai Berger wrote: > > On Wednesday 02 December 2015 18:51:03 Aymeric Augustin wrote: > > > > We could implement a property that returns an object: > > > > - that is still callable, for backwards compatibility > > - that evaluates correctly in a boolean context > > > > Then we can consider deprecating the ability to call it. > > > > > > class CallableBool: > > > > def __init__(self, value): > > self.value = value > > > > def __bool__(self): > > return self.value > > > > def __call__(self): > > return self.value > > > > def __repr__(self): > > return 'CallableBool(%r)' % self.value > > > > CallableFalse = CallableBool(False) > > > > CallableTrue = CallableBool(True) > > > > More general alternative: > > class IdempotentCallMixin(object): > def __call__(self): return self > > However, you can't extend bool, so > > class CallableBool(IdempotentCallMixin, bool): pass > > does not work, and you'd have to do something like > > class CallableBool(IdempotentCallMixin, int): pass > > which is less nice (because of __repr__ etc) > > Shai > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/15da4606-c327-4b1e-bc1c-fc309c6955ba%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
