The patch is 5 years old and doesn't apply cleanly, so it needs improvement in that sense but that shouldn't be difficult. The main blocker to getting it merged looks like "Needs tests."
On Tuesday, February 2, 2016 at 10:58:40 AM UTC-5, Federico Capoano wrote: > > Hi Tim, > > thank you for letting me know of the open ticket. > The "patch needs improvement" flag is set to "no". Is that correct or not? > > Federico > > On Mon, Feb 1, 2016 at 1:18 PM Tim Graham <timog...@gmail.com > <javascript:>> wrote: > >> Here is an accepted ticket: https://code.djangoproject.com/ticket/13875 >> >> Feel free to update and/or improve the patch, add tests, and send a pull >> request. Thanks! >> >> >> On Monday, February 1, 2016 at 6:18:35 AM UTC-5, Federico Capoano wrote: >>> >>> Hi all, >>> >>> I came across the need of modifying the submit row functionality in the >>> django admin and I found out a small issue which prevents me from modifying >>> the template without rewriting (duplicating) also the templatetag entirely. >>> >>> If you take a look at the code of submit_row templatetag >>> <https://github.com/django/django/blob/master/django/contrib/admin/templatetags/admin_modify.py#L41-L70>, >>> >>> you will notice the original view context is not passed entirely to the >>> return statement. A new ctx dictionary is created and filled only with a >>> smaller subset of key/value pairs. >>> >>> I took a quick look at other template tags and I noticed they return the >>> entire context and not a stripped version of it. >>> >>> I would prefer submit_row to behave in the same way as the other >>> templatetags so I wouldn't have to duplicate its code to add new context >>> values to it. >>> If there's consensus on this issue I can create a ticket and send a pull >>> request, let me know. >>> >>> Federico >>> >> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "Django developers (Contributions to Django itself)" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/django-developers/yrngp53RvxY/unsubscribe >> . >> To unsubscribe from this group and all its topics, send an email to >> django-develop...@googlegroups.com <javascript:>. >> To post to this group, send email to django-d...@googlegroups.com >> <javascript:>. >> Visit this group at https://groups.google.com/group/django-developers. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/bbb82460-8a55-47ff-8e7f-acfc063f6cf0%40googlegroups.com >> >> <https://groups.google.com/d/msgid/django-developers/bbb82460-8a55-47ff-8e7f-acfc063f6cf0%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/0dfaacf4-49d4-4201-8ee8-080925c33545%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
