Thanks, I will! Jonas
Am Mittwoch, 30. November 2016 22:31:19 UTC+1 schrieb Adam Johnson: > > I suspect it was simply to make it easier to work with. > > I'd suggest you create a ticket at > https://code.djangoproject.com/newticket and then try making the change > and seeing if Django's test suite still passes. All the information you > should need is at > https://docs.djangoproject.com/en/dev/internals/contributing/ . > > On Wednesday, November 30, 2016 at 9:17:49 PM UTC, Jonas von Poser wrote: >> >> Hi everybody, >> >> we've run into an interesting situation: we implemented a custom >> SimpleListFilter for the admin which presents the choices as a list of >> checkboxes. Pressing "submit" sends the list to the backend for filtering. >> >> Unfortunately, this doesn't really work well and it took us a while to >> find out why: the ChangeList view request.GET (a QueryDict) into a dict >> <https://github.com/django/django/blob/master/django/contrib/admin/views/main.py#L67> >> . >> >> This means, a query string in the form of ?q=123&state=1&state=2 simply >> loses all state values except the last one. It still works in principle >> but as soon as you e.g. click on a column heading to re-sort, the link >> breaks. >> >> I checked the git log and traced this re-casting back to the "NEW ADMIN >> MERGE >> <https://github.com/django/django/commit/9dda4abee1225db7a7b195b84c915fdd141a7260#diff-ea7d8c684e252f3dad6aa458df7d3070R109>" >> >> in 2005. Does anyone know why this was done? Shouldn't we rather keep >> self.params as a QueryDict? >> >> Thanks! >> >> Jonas >> > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/6a02ff82-1557-466b-ab4a-57e5982e20b9%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
