While working on a project that calls the `authenticate` function from 
contrib.auth directly, I noticed that the user_login_failed signal is sent 
from it but not user_logged_in.

I looked into the code and indeed, the user_logged_in signal is only sent 
from the higher-level `login` function. I would expect to be able to 
connect to either both signals or none. Since backends may call 
authenticate directly without going through login, perhaps it would be best 
to move the user_login_failed to `login` and let custom backends implement 
both signals manually if they need them.

What do you think?

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/6a63a35c-8e45-4dd2-91e6-74436443ee86%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to