I would expect test data population to happen using migrations rather than in the test runner. Can you elaborate on your use case and say if that method would be unsuitable?
On Friday, April 28, 2017 at 8:45:55 PM UTC-4, Marcos Diez wrote: > > Ticket: https://code.djangoproject.com/ticket/28153 > Pull Request: https://github.com/django/django/pull/8437 > > Although Django makes very easy for one to extend > django.test.runner.DiscoverRunner > , it's setup_databases() does too much. > > Currently, it > > - creates all the test databases (for single thread unit tests) > - duplicates all the test databases (in case of parallel unit tests) > > In case I am running not running tests in parallel, I can just populate > the DB after running unit tests without any issues. > > > But if I care about my time and want to run tests in parallel, I can > either: > > > a) populate my data after setup_databases() is executed, once for each > thread of the parallel tests, which is slow > b) get my hands dirty and reimplement setup_databases() > > > I propose (and I am sending the code to do so) a better solution. We just > have to break setup_databases() in 3 functions: > > > DiscoverRunner.prepare_databases() > DiscoverRunner.populate_databases() # noop by default > DiscoverRunner.duplicate_databases_if_necessary() > > > The idea is quite simple: in order to be backward compatible, > setup_databases() > , will still exist but only call three functions above in that order. > > > The first function will create all the test databases necessary for non > parallel tests to run. > > populate_databases() , which should be a no op, can be overwritten by the > user who extends django.test.runner.DiscoverRunner so his/her data can be > populated > > > Afterwards, all the test DBs are copied as many times as necessary in case > parallel tests are run via DiscoverRunner.duplicate_databases_if_necessary() > > > > I believe this change on Django will have no downside, will be backward > compatible and help people who needs to populate real data on the DB for > their tests. > > > Thanks > > Marcos Diez > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/817344bd-57c1-42e9-a5b6-8550934c89b5%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
