> Therefore I'd favor we keep the current adjustment in the master branch 
as it
> restores backward compatibility but I don't have strong feelings about 
reverting
> it either if it's deemed inappropriate.

Fixing the crash is the number 1 priority in my opinion, as it broke 
something that used to work.

Optimising aggregation for unmanaged models is a distant second goal. Make 
it right. Then make it fast.

It'd be nice to provide said optimisation for unmanaged models provided 
there was a palatable way of doing so. I'm not sure how users would be able 
to use your callable approach without subclassing the backend - unless that 
is the intention? Getting feedback from the reporters would be good of 
course.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/16e9386f-856f-4730-85a1-69ff1545a04c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
  • Post... charettes
    • ... Josh Smeaton
    • ... jroes
    • ... Dylan Young
    • ... Matthew Pava
    • ... vojtech.bocek via Django developers (Contributions to Django itself)

Reply via email to