Please keep the conversation just on the pull request, and don't bug for review after a day. There are many patches to review, and half the work is done by volunteers in their spare time (I am one). Beware that there are 11,195 people subscribed to this mailing list.
On 21 January 2018 at 07:56, <askpriya...@gmail.com> wrote: > Hello ! > > I have updated the PR as per Adam's review. However, I have not changed > L155 in backends/postgresql/base.py from > > if settings_dict['NAME'] is not None > > to > > if 'NAME' in settings_dict > > > *None may be used to connect to the default 'postgres' db. * > > *However, "if 'NAME' in settings_dict" prevents KeyError, but would still > return True if 'NAME' is assigned a 'NoneType'. * > > (Referred test_default_name method in tests/backends/base/test_ > creation.py) > > I tried testing Adam's suggestion on this, but it results in the following > error: > > TypeError: object of type 'NoneType' has no len() > > The PR is still open and needs review. > > Thanks and regards ! > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/django-developers/a494f2b1-3923-405b-8eed- > 55f75497a239%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/a494f2b1-3923-405b-8eed-55f75497a239%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- Adam -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM2MnmR72kRjF%3DB0tdrcdOU8Xv5QZ48Vz5JJV1r4gCD_LA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
