Heya, Curtis! The gzipped file size of the new file is 82K. That's with all 19,999 passwords from Royce's list.
I threw together a quick test that compares the default list to the new larger one by checking 10,000 random passwords. Speed difference is negligible, with both varying between 0.8–1.1 seconds on my machine. Memory usage on the other hand is definitely higher. With the current Django list of 1,000 passwords memory usage increases by 0.1MiB. With the new list it's 0.9-1.0MiB. This would be expected, since the list if 20x the size. To put it into context, the project that I can that test on (a fresh project using the standard template) was already using 30MiB to run the management command. You can see the full output of the memory test here: https://gist.github.com/sesh/c431b8cc6b5063e31f08b2a4dc3b46f0 I think the trade-off of a little extra memory is worth it. If you *really* want to save memory you can (should?) disable the common password validator or provide your own shorter list anyway. On 30 March 2018 at 16:31, Curtis Maloney <cur...@tinbrain.net> wrote: > By which I mean... hi Brenton! Great to see you being active again :) > > It's great you've taken the time to do this, and the benefits are very > clear [improved security], but what are the costs? > > Whilst you're at it, what is the new file size? > > -- > Curtis > > > > > On 03/30/2018 04:26 PM, Curtis Maloney wrote: > >> What sort of performance impact is this having over the existing list? >> >> What's the additional memory load, if any? >> >> -- >> Curtis >> >> >> On 03/30/2018 04:24 PM, Brenton Cleeland wrote: >> >>> Three years ago Django introduced the CommonPasswordValidator and >>> included a list of 1,000 passwords considered to be "common". That list was >>> based on leaked passwords and came from xato.net[1]. >>> >>> I'd like to update the list to >>> >>> a) be from a more reliable / recent source >>> b) be larger and more in line with the NIST recommendations >>> >>> Security researcher Troy Hunt has published a massive list of leaked >>> passwords, including frequencies on Have I Been Pwned[2]. The top 20,000 of >>> which are available in a gist from Royce Williams[3], including the >>> frequency, md5 hash and plain text password. >>> >>> Interestingly there's 27 passwords in the Django list that aren't in the >>> HIBP list. I'd post them here but they're mostly short and not safe for >>> work. >>> >>> I've created a ticket for the increase in size[4] but wanted to check in >>> and make sure this is something django-developers thinks is valuable. >>> >>> Cheers, >>> Brenton >>> >>> [1]: https://web.archive.org/web/20150315154609/https://xato.net/ >>> passwords/more-top-worst-passwords/#.Wr3H1chxV25 >>> [2]: https://haveibeenpwned.com/Passwords >>> [3]: https://gist.github.com/roycewilliams/281ce539915a947a23db17 >>> 137d91aeb7 >>> [4]: https://code.djangoproject.com/ticket/29274 >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Django developers (Contributions to Django itself)" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to django-developers+unsubscr...@googlegroups.com <mailto: >>> django-developers+unsubscr...@googlegroups.com>. >>> To post to this group, send email to django-developers@googlegroups.com >>> <mailto:django-developers@googlegroups.com>. >>> Visit this group at https://groups.google.com/group/django-developers. >>> To view this discussion on the web visit https://groups.google.com/d/ms >>> gid/django-developers/0a215878-9d3f-4446-a018-602694f54904% >>> 40googlegroups.com <https://groups.google.com/d/m >>> sgid/django-developers/0a215878-9d3f-4446-a018-602694f54904% >>> 40googlegroups.com?utm_medium=email&utm_source=footer>. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> > -- > You received this message because you are subscribed to a topic in the > Google Groups "Django developers (Contributions to Django itself)" group. > To unsubscribe from this topic, visit https://groups.google.com/d/to > pic/django-developers/oMWLVK5kTpI/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit https://groups.google.com/d/ms > gid/django-developers/2cb005ec-5f22-a77e-ddeb-791ab85ff03c%40tinbrain.net. > > For more options, visit https://groups.google.com/d/optout. > -- Cheers, Brenton https://brntn.me // @sesh <https://twitter.com/sesh> -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAC_Rtmu6CAyzMyRGvR1H_3aBKyYnqemf0_GTuVkdyJJWBx7XBg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
