Hello Arthur, I agree that option 1 is the way to go.
It would be nice to make the migration reversible. If someone upgrades to Django 2.2.x, migrates the database, and later discovers a blocking issue, they should have the option to migrate backwards and downgrade to 2.1.y. Best regards, -- Aymeric. > On 26 Nov 2018, at 16:10, Arthur Rio <arthur.ri...@gmail.com> wrote: > > Hi all, > > I have been working on a 9 years old ticket that I'd like to close once and > for all. The outstanding question is about the migration path to choose in > order to update existing proxy model permissions. I have explained three > different approaches I can think of in the pull request: > https://github.com/django/django/pull/10381#issuecomment-435534644. > > I have implemented the first option and wrote the release notes explaining > what to expect for users upgrading: > https://github.com/django/django/pull/10381/files#diff-1f22a5c1d6164c6de8defb36f3829138. > > Carlton, who has been the main reviewer, suggested to contact the mailing > list for further review in order to catch any red flag and make sure we have > general consensus on the chosen approach. > > Regards. > > Arthur > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com > <mailto:django-developers+unsubscr...@googlegroups.com>. > To post to this group, send email to django-developers@googlegroups.com > <mailto:django-developers@googlegroups.com>. > Visit this group at https://groups.google.com/group/django-developers > <https://groups.google.com/group/django-developers>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/f3298dbb-e072-4815-944c-2250d0b4d3a3%40googlegroups.com > > <https://groups.google.com/d/msgid/django-developers/f3298dbb-e072-4815-944c-2250d0b4d3a3%40googlegroups.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/46CD821B-C17E-4FF8-B623-6B40B0FB0BBD%40polytechnique.org. For more options, visit https://groups.google.com/d/optout.
