Well, it might not be the most valuable thing to work on, but if it helps you get comfortable with the code base and the changes are low to zero risk, it’s not so bad. I think there might be a smaller set of changes that reduces the risk.
On Mon, 18 Mar 2019 at 23:08, Alexey Tsivunin <[email protected]> wrote: > Thanks for your feedback! I'll make a PR in the coming days. I just needed > to know does anyone else think this code needs refactoring or I'm doing > useless work. > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/d077dd35-39e1-48a4-907e-6c488926f95a%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/d077dd35-39e1-48a4-907e-6c488926f95a%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- Adam -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM3QGt4XLm6NRvc_k78SqkSjxO_KvuNLEvYAu3TdGGvzpA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
