On Sun, Apr 14, 2019 at 3:11 AM Nick Sarbicki <nick.a.sarbi...@gmail.com> wrote:
> Just going to say that one of the main frustration points I've had when > making a contribution is having to fix small formatting errors (often minor > things in docstrings which aren't _always_ consistent). > I constantly need to be reminded to shorten docstrings and comments (and sometimes remove "We" from the beginning of such strings). Unfortunately (though understandably), Black won't help with any of these issues, and we'll still be left with the same back and forth about grammar, wrapping, etc. in comments and docstrings. (Again, as of mid-2018 there is the max-doc-length option for flake8 that could help with this somewhat, but that change can be made independently.) I'm not arguing against Black adoption, but I don't think it's going to eliminate from the review process what may sometimes feel like inertia... Tobias -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMGFDKSykRi_51ZonvETYX7whWnPmEAVKm76-MxZifeEuqMt-A%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
