Le samedi 20 avril 2019 09:11:24 UTC+2, Carlton Gibson a écrit :
>
>
>
> On Friday, 19 April 2019 20:33:13 UTC+2, Mariusz Felisiak wrote:
>>
>>
>> I don't think that our code style is any barrier for newcomers. ...we've
>> never blocked any patch due to stylistic nitpicks. I also don't believe
>> that it will increase the number of contributors, if I would like to
>> contribute to any package it wouldn't matter to me.
>>
>
> So, I've been out banging the drum for new contributors for a year or so
> now. I've had a number of personal reports that this just isn't true.
>
> Members of our community who want to contribute to Django are finding the
> review process off-putting. (They've used stronger language than that.) We
> have a host of people that have made a single contribution and never come
> back.
>
> "Wrap to 79 chars", or whatever, would be better gone. I'm not sure I like
> Black per se, but using an auto-formatter would enable review comments to
> focus on substantive points. ("Can we rephrase this slightly to more
> like....") (From experience in Go and Elm lands, the community using a
> single formatter has great benefits. After a couple of week your brain gets
> used to the different style.)
>
> It's not a panacea. But we have a massive barrier to entry. We need to
> address that. Using an auto-formatter would be one step.
>
Sorry, but I cannot believe that the coding style is a hurdle in our review
process. Most Python devs should already write mostly PEP-8 compliant code.
Let me repeat what I already said in other threads: contributing to Django
today is hard because:
1. The low-hanging fruits are gone and most tickets are now non-trivial to
solve.
2. Our quality expectations are high (tests, docs, backwards compatibility)
and I don't think we should sacrifice any of those requirements just to get
more contributors.
I think that we are at a point where asking a single person to handle a
ticket from writing code down to the final commit is becoming a too heavy
task (at least for newcomers). In my opinion, we should find a way to
better split the various tasks involved in solving a ticket among several
contributors.
This should be the subject of another thread probably. It is somewhat
related to this thread in the sense that if the syntax polishing is simply
ignored at first and deported to a pre-commit step (I'm sure we'll find
people willing to do that part), then this issue is moot. We could imagine
for example that isort/flake8 patch checks are only run at final stages of
a patch process.
Claude
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/72e62389-eb9a-4c28-beb1-2cfdf488f4e9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
