On Fri, Apr 19, 2019 at 6:33 PM Mariusz Felisiak <felisiak.mari...@gmail.com> wrote: > I don't think that our code style is any barrier for newcomers.
As a newcomer, I can tell you that it most definitely is a barrier, at least it is for me – for the reasons laid out in my original email :) * >From what I can gather the following arguments have been raised against Black: - I don't like the formatting style (double quotes, white-space, line length, wrapping, ...) - It produces one huge diff - It, in some situations, produces weird formatting (lists with comments, ...) - It doesn't solve an issue that we currently have At the end of the day some of these arguments are just personal opinions and comes down to preference. However a lot of counter-arguments have been made and I'll just shortly summarize them here: * I don't like the formatting style We will never collectively agree on "the perfect" formatting and many do not agree with the *current* formatting. The time spent having these non value-adding discussions are not worth it, and Black would eliminate them to to a large extent. * It produces one huge diff There are tools to work around this (git-hyper-blame [0]), Github has a great UI for browsing diffs and it looks like in the future it will be possible to exclude certain commits from blame history [1]. * It, in some situations, produces weird formatting A lot of these can be remedied my using `--target-version=py37` as the AST does not change in newer versions of Python. Other files (like settings) can be either disabled from auto-formatting or we can disable parts of the file with `# fmt: off`. * It doesn't solve an issue that we currently have I, and a lot of people have expressed this too, feel like it definitely solves a very real problem. Formatting of code delays PRs, wastes time, makes it harder to contribute as a newcomer, is an extra cognitive load for all of us, and produces loads of wasteful discussions. I'm sure there are more arguments made too, I'm sorry if I missed some, but these seem to be repeated most often. * I favor adopting the default configuration (88 width, double quotes) in one go and just be done with it. It's not as scary as it seems and it really just makes the day a tiny bit easier :-) What has usually been the process of democratically deciding these "controversial" topics in the past? From what I gather there is a clear majority favoring Black, but I'm curious as to when and how we decide to end the discussion either for or against. Kind regards, [0]: https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html [1]: https://public-inbox.org/git/20190410162409.117264-1-b...@google.com/ -- Herman Schistad -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAN%3DnMTywHoSuccTi4krcXwfKDNu67mg1HKfmqk0LR94vBLFa%3Dg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
