Hi Aymeric, On Saturday, November 20, 2021 at 12:39:17 PM UTC+1 Aymeric Augustin wrote:
> I'm not trying to disagree for the sake of disagreement; I'm just trying > to bring some contextual awareness and avoid the "core devs say > ATOMIC_REQUESTS is bad" effect. I hope we can agree on this? > Absolutely, my comment was mostly there to show that not all core devs agree that ATOMIC_REQUESTS is something that should be always enabled. As usual it depends on your project, database etc… I should have added more context to that, thanks for pointing it out. > Finally — yes, I know that my implementation of this feature is a wormhole > across layers. I won't even try to justify it. I wish we had something > better but we haven't found that yet. > I still think it is good (in the sense that we worked with what we had available). Sure the layering isn't exactly nice, but we have worse things in Django's codebase :) I even have a possible fix for that, but it requires us to rewrite middlewares again :/ Cheers, Florian -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/6d65a33b-32ad-46a0-9b75-9c7f96c1fe03n%40googlegroups.com.
