Hi Adrian,

I agree this would be nice to have.

On Friday, March 4, 2022 at 8:03:09 PM UTC+1 ator...@redhat.com wrote:

> Another idea would be to use configure_user() for both initial 
> configuration and synchronization by passing an extra parameter "created" 
> to it, and calling it just before the authenticate method's return line, 
> but I figured this change would be more disruptive for existing 
> implementations. 
>

I do prefer that approach. It is not more disruptive (or at least only 
marginally) and only means more work (backwards compat warnings) when 
implementing this. We can easily inspect the existing signature and only 
pass the boolean when supported and in the backwards compatibility period 
simply do not support created=False when the user didn't change their 
configure_user signature. I'd hate seeing two methods that basically do the 
same.

Cheers,
Florian 

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/9db3b605-a8fc-40ab-a318-0ff1e7a76eb3n%40googlegroups.com.

Reply via email to