Big +1. IMO tags should work like HTML tags, which can be spread across multiple lines, as often done with multiple attributes. Also, Jinja does it.
If you're going to write a DEP, I'd say don't make it too long. The feature is clear enough. The old PR <https://github.com/django/django/pull/2556> is also short, as it affects only the lexer. It should rebase fairly well as the lexer won't have changed much. I would plan to test it with as many templates as possible, to ensure that the tokenization is the same before/after. Happy to review... I'm planning on copying the lexer into django-upgrade so it can upgrade template files, so I would like to have some familiarity with it. On Wed, Sep 28, 2022 at 1:40 PM Alex Morega <a...@grep.ro> wrote: > Hi Thibaud, > > I don't have many contributions to Django, but FWIW, I'm happy to help > with development. > > On Wednesday, September 28, 2022 at 1:42:11 PM UTC+3 carlton...@gmail.com > wrote: > >> Hey Thibaud. >> >> Thanks for following up! Yes ā happy to sheppard. >> >> (My other comment was to make sure the Rationale was sufficiently >> clear/compelling, but I know you're on that š) >> C. >> >> On Wed, 28 Sept 2022 at 12:24, Thibaud Colas <thibau...@gmail.com> wrote: >> >>> Just wanted to follow up that I got to discuss this in person with >>> Carlton Gibson at the DjangoCon Europe sprints in Porto, who provisionally >>> offered to act as a shepherd for this proposed DEP. This is on the >>> condition that I find an implementation team as well. >>> >>> On Saturday, 24 September 2022 at 08:37:52 UTC+1 Thibaud Colas wrote: >>> >>>> š Hi django-developers, I would like to revisit a very old feature >>>> request: ticket #8652 Multiline tags and tag escape tags >>>> <https://code.djangoproject.com/ticket/8652>, proposed DEP Multiline >>>> Template Tags <https://github.com/django/deps/pull/3>, and maling list >>>> thread Revisiting multiline tags >>>> <https://groups.google.com/g/django-developers/c/wRKgnMIhl6g/m/hMRHPIz4CgAJ> >>>> . >>>> >>>> There have been a lot of cases made against and for multiline template >>>> tags across many threads. Iām raising this on the mailing list not >>>> necessarily to revisit those arguments but to ask: >>>> >>>> 1. Is a DEP indeed the best way forward for this at this point in >>>> time? If so I will volunteer to author it (co-authors welcome!). >>>> 2. The last DEP got blocked due to the lack of an implementation >>>> team and shepherd. If we made a new (proposed) DEP ā is anyone here >>>> interested in helping in either positions? >>>> >>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Django developers (Contributions to Django itself)" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to django-develop...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/django-developers/ddc74d02-63df-479a-968c-2ee44b696bd2n%40googlegroups.com >>> <https://groups.google.com/d/msgid/django-developers/ddc74d02-63df-479a-968c-2ee44b696bd2n%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/af3c7629-4f7c-42b7-bb98-a0a67ef9af07n%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/af3c7629-4f7c-42b7-bb98-a0a67ef9af07n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM1vF4rh7e2dTV3jp2tYH%3DVFz%3DuwSFqeSoHKjnPASMVdaQ%40mail.gmail.com.
