Adding my support for the suggested approach. Start small and central and step-by-step. 👍
> (I'm going to add a link in django-anymail's "you probably don't need proprietary ESP templates <https://anymail.dev/en/stable/tips/django_templates/>" docs.) Thanks! Much appreciated! And thx on your thoughts about the class-based emails. I do agree that we should start with the proposed changes. Then we'll worry about the high-level stuff. Best regards from Cologne Ronny PS: Sorry for misspelling Jacob Rief in my earlier posting! Florian Apolloner schrieb am Freitag, 28. Juni 2024 um 22:07:35 UTC+2: > Hi Mike, > > overall the plan sounds good. I especially like the approach to "fix" the > tests first. This can happen in an extra merge request and reviewed > independently so we can be sure that we are still testing what we want to > test before moving to the tricky parts. > > On Thursday, June 27, 2024 at 3:28:06 AM UTC+2 Mike Edmunds wrote: > > > 1. > > Deprecate unused internal APIs from django.core.mail.message > > Django will no longer need these (Python's modern email API covers > their functionality), but they may be in use by third-party libraries: > - utf8_charset > - utf8_charset_qp > - RFC5322_EMAIL_LINE_LENGTH_LIMIT > - BadHeaderError^ (more details below) > - ADDRESS_HEADERS > - forbid_multi_line_headers()^ > - sanitize_address() (more details below) > - MIMEMixin > - SafeMIMEMessage > - SafeMIMEText^ > - SafeMIMEMultipart^ > > (Items marked ^ are exposed in django.core.mail via __all__. I haven't > looked into the reason for that.) > > > Are all of those documented? If not we can simply remove them (especially > if the deprecation implementation turns out to be a PITA). > > Cheers, > Florian > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/b8d51b07-321b-4540-8188-46cd0b9a711fn%40googlegroups.com.
