I am not sure if this is relevant for the PR as I haven't thoroughly looked into it but the effective price in Prices (in partner) controls on what the discount will be applied (incl or excl tax). Has the settings OSCAR_OFFERS_INCL_TAX got to do anything with it?
On Thursday, October 18, 2018 at 3:35:21 PM UTC+5:30, Web Architect wrote: > > Overriding line_price_incl_tax_incl_discounts and line_tax based on the PR > did the trick. I got the calculations I needed. I had thought this could be > handled in strategy instead of the line properties. I didn't include the > settings for discount including tax as that won't be needed. Would look > forward to 2.0 for the overall feature. > > Thanks. > > On Thursday, October 18, 2018 at 12:10:58 PM UTC+5:30, Web Architect wrote: >> >> Hi Samir, >> >> Thanks for your response. I am still looking into the PR but I am not >> sure if it does the following: >> >> Let's say product price excl tax is INR 100 and line quantity is 1. >> >> Customer applies a coupon discount of INR 10. Hence, the line price excl >> tax including discount would be INR 90 (INR100 x 1 - INR 10). >> >> Now the line tax needs to be applied on INR 90. If the tax rate is 10%, >> the line tax will be INR 9. >> >> The above calculation is only for the basket line. >> >> Is the PR doing something like the above? Would appreciate >> clarification... >> >> Thanks. >> >> >> On Thursday, October 18, 2018 at 10:18:03 AM UTC+5:30, Samir Shah wrote: >>> >>> It sounds like what you want is implemented in this PR: >>> https://github.com/django-oscar/django-oscar/pull/2804 , which will be >>> part of Oscar 2. Until then you might be able to take the implementation >>> there and override the logic in your project to achieve the same thing. >>> >> -- https://github.com/django-oscar/django-oscar http://django-oscar.readthedocs.org/en/latest/ https://twitter.com/django_oscar --- You received this message because you are subscribed to the Google Groups "django-oscar" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-oscar+unsubscr...@googlegroups.com. Visit this group at https://groups.google.com/group/django-oscar. To view this discussion on the web, visit https://groups.google.com/d/msgid/django-oscar/042c1041-9e7b-4538-96ec-bba73d8f0d05%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
