#2507: [patch] LDAPBackend in django/contrib/auth/backends.py
--------------------------------+-------------------------------------------
Reporter: [EMAIL PROTECTED] | Owner: adrian
Status: new | Component: Contrib apps
Version: | Resolution:
Keywords: | Stage: Accepted
Has_patch: 1 | Needs_docs: 1
Needs_tests: 0 | Needs_better_patch: 1
--------------------------------+-------------------------------------------
Comment (by Scott Paul Robertson <[EMAIL PROTECTED]>):
Works out of the box with my OpenLDAP setup. I didn't need to change any
settings.
I've attached a slight modification of the patch which changes:
1. The except statement when we bind as the user to catch the case where
someone doesn't enter their password.
1. Minor adjustments to the internal documentation to clear up the
wording and remove some now obsolete statements.
Also, why are the calls to the ldap module always done as self.ldap? It
works either way, and removing the self would be cleaner code in my
opinion.
Do we want to create the contrib directory? auth is already a contrib and
it seems a bit excessive to have a contrib in contrib, but that just might
be me.
It does seem that the documentation should be in a subdirectory. Maybe we
can just write it up in the current authentication page for now.
I'm all for a LDAP_ATTR_MAP, it seems like a much cleaner method, and
should be easy to maintain current functionality.
Group membership isn't the same between AD and OpenLDAP. OpenLDAP has
group objects with have lists of users. We should go for a base
LDAPBackend (which doesn't bother with groups), and subclass it for AD and
OpenLDAP.
Looks good, thanks for the work, Scott
--
Ticket URL: <http://code.djangoproject.com/ticket/2507#comment:9>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
