#19792: django.test.client.Client.login() checking for is_active attribute on
User
objects
-----------------------------------+------------------------------------
Reporter: mrmagooey | Owner: slurms
Type: Bug | Status: assigned
Component: Testing framework | Version: 1.5-rc-1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------------+------------------------------------
Comment (by slurms):
Hmm, on second thought, I guess the inconsistency lies with the
`@login_required` decorator. If we expect the test client to work like the
`contrib.auth.login` view, the `is_active` check should remain. Even with
custom auth backends the `Client.login()` method works in much the same
way as `contrib.auth.login`.
Though it is a bit confusing that Jacob has said that `is_active` is
purely for custom auth sources and that the built-in stuff doesn't use it.
Is that the expected behaviour and should the `AuthenticationForm`
`is_active` check also be removed?
--
Ticket URL: <https://code.djangoproject.com/ticket/19792#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
