#19792: django.test.client.Client.login() checking for is_active attribute on
User
objects
-----------------------------------+------------------------------------
Reporter: mrmagooey | Owner: slurms
Type: Bug | Status: assigned
Component: Testing framework | Version: 1.5-rc-1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------------+------------------------------------
Comment (by claudep):
No, the `is_active` check cannot be removed in `AuthenticationForm`. I'm
convinced that numerous sites are counting on this behaviour.
The `login_required` decorator is basically checking
`request.user.is_authenticated()`, and a user with `is_active=False` will
not be authenticated with standard `contrib.auth.login`.
I'd tend to won't fix this ticket, unless we get a convincing use case of
removing this check.
--
Ticket URL: <https://code.djangoproject.com/ticket/19792#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
