#19464: The markup for ClearableFileInput's link should be a widget template
string
-------------------------------------+-------------------------------------
Reporter: rubyruy | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version:
Severity: Normal | 1.5-beta-1
Keywords: widget | Resolution:
ClearableFileInput | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by carljm):
* needs_docs: 1 => 0
* needs_tests: 1 => 0
Comment:
I agree that this is an internal refactoring for better subclassability
and does not require new tests, only that all existing tests pass.
A case could be made that if we're refactoring widget implementations
specifically to make them more easily subclassable, we should also
document those class attributes intended for overriding; otherwise we're
encouraging reliance on undocumented implementation details. I don't feel
strongly enough about that to block this going in, though.
--
Ticket URL: <https://code.djangoproject.com/ticket/19464#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
