#20861: 500 status code debugging view shouldn't localize numeric tags IDs/line
numbers
--------------------------------------+------------------------
               Reporter:  ramiro      |          Owner:  nobody
                   Type:  Bug         |         Status:  new
              Component:  Utilities   |        Version:  master
               Severity:  Normal      |       Keywords:
           Triage Stage:  Unreviewed  |      Has patch:  0
    Needs documentation:  0           |    Needs tests:  0
Patch needs improvement:  0           |  Easy pickings:  0
                  UI/UX:  0           |
--------------------------------------+------------------------
 Contributor Kronuz opened a pull request
 (https://github.com/django/django/pull/451) with a proposed fix to the
 issue.

 I've added tests here: https://github.com/django/django/pull/1437

 One thing missing in the proposed fix was importing the `l10n` template
 tag library (the one that contains the `unlocalize` filter) and this
 stopped me from merging the PR right away.

 Until now the template is pretty self-contained and lean, e.g. it doesn't
 import template tag libraries (I suspect to minimize the risk of
 triggering other problems when trying to show a helpful version of the
 server error exceptions.)

 Should I ignore all this and simply commit the fix?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/20861>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.5e66301c7dd905bf650f6b0417807202%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to