#21051: Move cookie settings from standalone values to dictionaries
-------------------------------------+-------------------------------------
Reporter: ramiro | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Core (Other) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: cookie cookis csrf | Needs documentation: 0
sesssion language | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):
* needs_better_patch: 0 => 1
Comment:
After discussion with Ramiro on IRC, we're not sure if we should move
forward with this. Using a dictionary has the problem that default
settings from `django/conf/global_settings.py` would be lost if only
overriding part of the `SESSION_COOKIE` dictionary. I proposed the
possibility of adding a shim to the settings setter to merge the two
dictionaries, but I'm not sure if this is feasible or worth it.
Marking as "patch needs improvement", but leaving it up to Ramiro as to
whether we should move forward or won't fix.
--
Ticket URL: <https://code.djangoproject.com/ticket/21051#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.cf75cc9729df6ebc612313eb1b76a6f8%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
