#21725: Javascript translations fail with non-BMP characters
-------------------------------------+-------------------------------------
Reporter: nedbatchelder | Owner: MattBlack
Type: Bug | Status: new
Component: | Version: 1.6
Internationalization | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by bmispelon):
I did some digging and as it turns out, `javascript_quote` is not used
anymore when doing javascript translation since
a506b6981bc48caec30bca3de94d2ac3e6fc1660.
In fact, this function is undocumented, barely tested, and was only used
internally for the `javascript_catalogue` view.
On top of that, it was also completely broken on Python2 if you ever
passed it non-ascii input.
I think we should just delete it altogether.
As for the test failure, they pass on my machine both with Python 2 and 3
and our CI server is also in the green. There's a chance it might be
related to a wide/narrow build of Python.
--
Ticket URL: <https://code.djangoproject.com/ticket/21725#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/071.43a7ae4bd59050e07e37612291f3507b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
