#23425: Hide oracle specific GIS behaviour behind a feature flag
--------------------------------------+--------------------
     Reporter:  jarshwah              |      Owner:  nobody
         Type:  Cleanup/optimization  |     Status:  new
    Component:  GIS                   |    Version:  master
     Severity:  Normal                |   Keywords:
 Triage Stage:  Unreviewed            |  Has patch:  0
Easy pickings:  0                     |      UI/UX:  0
--------------------------------------+--------------------
 There are several places where oracle is singled out in GIS. These checks
 should probably be pushed down into feature flags.

 Some examples:

 {{{
 # GeoAggregate.as_sql
     if connection.ops.oracle:
             self.extra['tolerance'] = self.tolerance
 }}}

 {{{
 # GeoQuery.get_aggregation
     if isinstance(aggregate, gis_aggregates.GeoAggregate):
         if not getattr(aggregate, 'is_extent', False) or
 connection.ops.oracle:
             self.extra_select_fields[alias] = GeomField()
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23425>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.a8e65ad26ac614a3c7c3c39a05fd95b6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to