#21648: Deprecate "is_admin_site" option of auth.views.password_reset()
--------------------------------------+------------------------------------
Reporter: brain@… | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by googol7):
Good question. I think that updating to the sites framework would be a lot
of overhead for us as we just provide a branded site based on the URL. I
don't know if this is a common setup but probably its worth thinking about
why the domain defined for a site shall be used for the password reset
link in the email and if it would be sufficient to just use
request.get_host() Because if the user visits the domain of the site
framework it's the current domain of the current request anyway.
--
Ticket URL: <https://code.djangoproject.com/ticket/21648#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/082.20b256335d4f80198cd8198ff3b3e01e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
