#23876: SQLAggregateCompiler.as_sql() accepts a compiler arg that it doesn't use
-------------------------------------+-------------------------------------
Reporter: carljm | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: 1.6
Component: Database | Keywords:
layer (models, ORM) | Has patch: 0
Severity: Normal | Needs tests: 0
Triage Stage: | Easy pickings: 0
Unreviewed |
Needs documentation: 0 |
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
It even goes to the trouble of setting the `compiler` arg to `self` if one
wasn't passed in; but then `compiler` is never used in the method.
Many of the other SQLCompiler subclasses have `as_sql` methods that don't
accept `compiler`, so it doesn't appear to be an invariant.
Test suite lasses without that argument, at least on SQLite. Will push a
cleanup PR to check if anything else breaks on CI.
--
Ticket URL: <https://code.djangoproject.com/ticket/23876>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/049.c5893ba85440ac785bc5fa87a43f326c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
