#24170: DateTimeRangeField: widget doesn't implement decompress()
-------------------------------------+-------------------------------------
Reporter: joelburton | Owner: ngzhian
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: 1.8alpha1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: DateTimeRangeField | Triage Stage: Accepted
decompress |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by MarkusH):
* needs_docs: 0 => 1
* has_patch: 0 => 1
* type: Uncategorized => Cleanup/optimization
* needs_tests: 0 => 1
Comment:
Replying to [comment:4 ngzhian]:
> Implemented it and submitted a PR, it's lacking test though, I'm not too
sure how to test it. Will creating a field of each type
`IntegerRangeField`, `FloatRangeField`, `DateTimeRangeField`, and
`DateRangeField` and asserting `self.widget.decompress()` be sufficient?
I'd have a look at the tests of the "normal" widgets if there aren't any
tests yet. I don't think there is a need to tests all range fields.
--
Ticket URL: <https://code.djangoproject.com/ticket/24170#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.a71158c093d190387a618476225e178b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
