#24605: [1.7.7] DB identifiers are not properly escaped in some case
(ProgrammingError: relation does not exist)
----------------------------------------------+----------------------------
Reporter: kurevin | Owner: nobody
Type: Uncategorized | Status: new
Component: Database layer (models, ORM) | Version: 1.7
Severity: Normal | Keywords: regresion,
| database
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------------------+----------------------------
Happens on 1.7.2-1.7.7, does not happens on 1.7.1
Rough setup:
{{{
Amodel:
bmodel = models.ForeignKey(Bmodel, related_name='Amodel_bmodel')
...
Cmodel:
amodel = models.ForeignKey(Amodel)
...
}}}
Depending on order of Q filters there are 2 outcomes:
{{{
>>> models.Amodel.objects.exclude(Q(active=False, bmodel__is_active=False)
& Q(cmodel__isnull=True)).query.__str__()
u'SELECT (...cut...) FROM "coreApi_amodel" INNER JOIN "coreApi_bmodel" ON
( "coreApi_amodel"."bmodel_id" = "coreApi_bmodel"."id" ) WHERE NOT
("coreApi_amodel"."active" = False AND "coreApi_bmodel"."is_active" =
False AND "coreApi_amodel"."id" IN (SELECT U0."id" AS "id" FROM
coreApi_amodel U0 LEFT OUTER JOIN "coreApi_cmodel" U1 ON ( U0."id" =
U1."amodel_id" ) WHERE (U1."id" IS NULL AND U0."id" =
(coreApi_amodel."id"))))'
>>> models.Amodel.objects.exclude(Q(active=False, bmodel__is_active=False)
& Q(cmodel__isnull=True))
Traceback (most recent call last):
File "<input>", line 1, in <module>
File ".../.venv/src/django/django/db/models/query.py", line 116, in
__repr__
data = list(self[:REPR_OUTPUT_SIZE + 1])
File ".../.venv/src/django/django/db/models/query.py", line 141, in
__iter__
self._fetch_all()
File ".../.venv/src/django/django/db/models/query.py", line 966, in
_fetch_all
self._result_cache = list(self.iterator())
File ".../.venv/src/django/django/db/models/query.py", line 265, in
iterator
for row in compiler.results_iter():
File ".../.venv/src/django/django/db/models/sql/compiler.py", line 700,
in results_iter
for rows in self.execute_sql(MULTI):
File ".../.venv/src/django/django/db/models/sql/compiler.py", line 786,
in execute_sql
cursor.execute(sql, params)
File ".../.venv/src/django/django/db/backends/utils.py", line 81, in
execute
return super(CursorDebugWrapper, self).execute(sql, params)
File ".../.venv/src/django/django/db/backends/utils.py", line 65, in
execute
return self.cursor.execute(sql, params)
File ".../.venv/src/django/django/db/utils.py", line 94, in __exit__
six.reraise(dj_exc_type, dj_exc_value, traceback)
File ".../.venv/src/django/django/db/backends/utils.py", line 65, in
execute
return self.cursor.execute(sql, params)
ProgrammingError: relation "coreapi_amodel" does not exist
LINE 1: ...pi_amodel"."id" IN (SELECT U0."id" AS "id" FROM coreApi_am...
^
}}}
Change Q order:
{{{
>>> models.Amodels.objects.exclude(Q(cmodel__isnull=True) &
Q(active=False, bmodel__is_active=False)).query.__str__()
u'SELECT (...cut...) FROM "coreApi_amodel" INNER JOIN "coreApi_bmodel" ON
( "coreApi_amodel"."bmodel_id" = "coreApi_bmodel"."id" ) WHERE NOT
("coreApi_amodel"."id" IN (SELECT U0."id" AS "id" FROM "coreApi_amodel" U0
LEFT OUTER JOIN "coreApi_cmodel" U1 ON ( U0."id" = U1."amodel_id" ) WHERE
U1."id" IS NULL) AND "coreApi_amodel"."active" = False AND
"coreApi_bmodel"."is_active" = False)'
>>> models.Amodels.objects.exclude(Q(cmodel__isnull=True) &
Q(active=False, bmodel__is_active=False))
[...results...]
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24605>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/050.b78bdccdee3c506d89682721fe2de1c2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
