#24676: Regression on ManytoMany representation in the admin interface
----------------------------------+--------------------------------------
     Reporter:  Etienne-Carriere  |                    Owner:  nobody
         Type:  Bug               |                   Status:  new
    Component:  contrib.admin     |                  Version:  1.8
     Severity:  Normal            |               Resolution:
     Keywords:                    |             Triage Stage:  Unreviewed
    Has patch:  0                 |      Needs documentation:  0
  Needs tests:  0                 |  Patch needs improvement:  0
Easy pickings:  0                 |                    UI/UX:  0
----------------------------------+--------------------------------------
Description changed by Etienne-Carriere:

Old description:

> Hi,
>
> We have discovered a small regression in 1.7 with the ManytoMany
> representation in admin page :
> '''Configuration to reproduce :'''
> * Have a many to many Field
> * Put the ManytoMany Field as a filter_horizontal block (I am not sure if
> it is mandatory)
>
> '''Behaviour :'''
>
> - Before the #13165 ticket commit, below the 'form-row' div, we have a
> second div (without class) and below this block is directly the different
> blocks
>   * The label
>   * The elements for the widget => in the same level as the other
> elements
>   * The help paragraph
> With the javascript in SelectFilter2 (in admin/js), the help paragraph is
> put on the first place of the div block (the one without class)
>
> - After the #13165, a div block ( 'related-widget-wrapper' ) has been
> added so that the second div looks like :
>   * The label
>   * A new div 'related-widget-wrapper'
>   * The help paragraph
>
> '''Proposal to solve'''
> I see 2 methods to solve the bug
> * Don't use the  'related-widget-wrapper' for the ManytoMany as the
> ticket #13165 was made only for the classical ForeignKey
> * Modify the SelectFilter2 js to adapt to the new block

New description:

 Hi,

 We have discovered a small regression in 1.7 with the ManytoMany
 representation in admin page :
 '''Configuration to reproduce :'''
 * Have a ManytoManyField
 * Put the ManytoManyField as a filter_horizontal block (I am not sure if
 it is mandatory)

 '''Behaviour :'''

 - Before the #13165 ticket commit, below the 'form-row' div, we have a
 second div (without class) and below this block is directly the different
 blocks
   * The label
   * The elements for the widget => in the same level as the other elements
   * The help paragraph
 With the javascript in SelectFilter2 (in admin/js), the help paragraph is
 put on the first place of the div block (the one without class)

 - After the #13165, a div block ( 'related-widget-wrapper' ) has been
 added so that the second div looks like :
   * The label
   * A new div 'related-widget-wrapper'
   * The help paragraph

 '''Proposal to solve'''
 I see 2 methods to solve the bug
 * Don't use the  'related-widget-wrapper' for the ManytoMany as the ticket
 #13165 was made only for the classical ForeignKey
 * Modify the SelectFilter2 js to adapt to the new block

--

--
Ticket URL: <https://code.djangoproject.com/ticket/24676#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.64b5336b22913b2af9137983db240eae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to